Buildmode & GM panel compatability #267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Breaks infestation and vent submenus via MMB for GM panel with usage. Did these get remapped? |
|
Not remapped, I forgot about them while implementing this. The GM menu needs to "own" the click while middle-clicking for those to work, but this changes it to only "owning" the click when one of the spawn/objective/etc on-click toggles is enabled. No current plans for this. It never became a big issue that needed solving, and I'm not sure this was the best way to solve it regardless (assuming I fixed the middle-click). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Allows multiple click intercept sources (ex/buildmode, GM panel, rappel panel) to coexist peacefully. It remembers all sources and the most recent source takes priority.
Instead of a single
click_intercept, there's now a list ofclick_intercepts. Any activated intercept source will add itself to the list, and will remove itself when deactivated. The last source in the list (the most recent) gets the clicks.Significantly adjusted how the GM panel handled its multiple intercepts to work with the new system. Should be the exact same for the user.
Explain why it's good for the game
Buildmode and the GM panel are used every round, frequently at the same time. This PR allows them to be used side-by-side in a much smoother way than one nuking the other's click intercept if that control is closed.
Testing Photographs and Procedure
Boots without issue. Tested having buildmode, GM panel, rappel panel all open at the same time. Closing one allows the others to still function.
Changelog
🆑
qol: buildmode & GM panel don't stomp on each other's clicks
/:cl: